Skip to content

Conversation

@tobiashofmann
Copy link
Contributor

The example won't work with the current incident numbers. 500 for warning and 800 for critical results currently that all numbers are formatted as default. Looking at the current numbers, values like 50 for default, 100 for warning and everything above gives a better result when running the example.

The example won't work with the current incident numbers. 500 for warning and 800 for critical results currently that all numbers are formatted as default. Looking at the current numbers, values like 50 for default, 100 for warning and everything above gives a better result when running the example.
@cla-assistant
Copy link

cla-assistant bot commented Jan 30, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Jan 30, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@akudev
Copy link
Contributor

akudev commented Jan 30, 2023

Well, it's not only this one place, but all the subsequent exercises and all the runnable versions in the gh-pages branch that need to be adapted. This is why we are shying away from keeping the limits all the time adjusted to the current incidence numbers.
And why a warning says:

You might need to adjust the incidence thresholds (which are hardcoded in this code snippet)
in order to see all three colors.

Are you willing to adapt the other places as well?

To see more than one color, we need at least one of the two thresholds to be between the lowest and the highest current incidence. With incidences changing together, it's hard to achieve this for more than a few weeks.

@petermuessig petermuessig requested a review from akudev March 28, 2023 08:32
@akudev
Copy link
Contributor

akudev commented Aug 7, 2023

Closing, as the updated tutorial no longer displays covid incidence numbers.

@akudev akudev closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants